This revision was automatically updated to reflect the committed changes.
Closed by commit rL345113: [clangd] Truncate SymbolID to 16 bytes. (authored by
sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53587?vs=170684&id=170
sammccall marked 2 inline comments as done.
sammccall added inline comments.
Comment at: clangd/index/Serialization.cpp:303
// A refs section has data grouped by Symbol. Each symbol has:
-// - SymbolID: 20 bytes
+// - SymbolID: 16 bytes
// - NumRefs: varint
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
We should watch out for the downstream backward compatibility.
Comment at: clangd/index/Index.h:92
// As USRs (Unified Symbol Resolution) could be large, especially for func
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
The goal is 8 bytes, which has a nonzero risk of collisions with huge indexes.
This patch should shake out any issues with truncation at
