[PATCH] D53541: [COFF, ARM64] Support SEH for ARM64 Windows

2018-10-31 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added a comment. In https://reviews.llvm.org/D53541#1282764, @mgrang wrote: > Updated the patch with the following changes: > > 1. Emit llvm.x86.seh.recoverfp only for non-aarch64 targets. For aarch64 > windows, the parent fp is always passed in x1. So we don't need a separate > instrinsic

[PATCH] D53541: [COFF, ARM64] Support SEH for ARM64 Windows

2018-10-31 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:471 + } + EH |= SEHExceptions; + I'm suspicious about adding a new default for AArch64 specifically; why do we need this if x86-64 doesn't? https://reviews.llvm.org/D53541 ___

[PATCH] D53541: [COFF, ARM64] Support SEH for ARM64 Windows

2018-10-31 Thread Mandeep Singh Grang via Phabricator via cfe-commits
mgrang updated this revision to Diff 171994. mgrang retitled this revision from "[COFF, ARM64] Add aarch64_seh_recoverfp intrinsic" to "[COFF, ARM64] Support SEH for ARM64 Windows". mgrang edited the summary of this revision. mgrang added a comment. Updated the patch with the following changes: