This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344745: [clangd] Clear the semantic of RefSlab::size.
(authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53389?vs=170063&id=170094#toc
Repository:
rL LLVM
http
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344745: [clangd] Clear the semantic of RefSlab::size.
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53389
Files:
clang-t
hokein added a comment.
In https://reviews.llvm.org/D53389#1268250, @sammccall wrote:
> Adding numRefs() and fixing occurrences makes sense.
> However I think `size()` needs to stay - it's an important part of the
> "container" concept, and e.g. GTest relies on it.
OK, and I added a comment f
hokein updated this revision to Diff 170063.
hokein added a comment.
- reserve the size name, added a comment indicating its senmatic.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53389
Files:
clangd/index/Background.cpp
clangd/index/FileIndex.cpp
clangd/index/Index.cpp
sammccall added a comment.
Adding numRefs() and fixing occurrences makes sense.
However I think `size()` needs to stay - it's an important part of the
"container" concept, and e.g. GTest relies on it.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53389
_
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
The RefSlab::size can easily cause confusions, it returns the number of
different symbols, rahter than the number of all references.
- rename s
