[PATCH] D53317: [clangd] Allow disble down traversals from root.

2018-10-16 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344604: [clangd] Allow disble down traversals from root. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D53317?vs=169804&id=169805#toc Repository: rCTE Clang

[PATCH] D53317: [clangd] Allow disble down traversals from root.

2018-10-16 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 169804. ioeric marked an inline comment as done. ioeric added a comment. - Simplify according to review suggestion. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53317 Files: clangd/FileDistance.cpp clangd/FileDistance.h unittests/cla

[PATCH] D53317: [clangd] Allow disble down traversals from root.

2018-10-16 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Works for me! I think the code can be simplified slightly. Comment at: clangd/FileDistance.cpp:135 } + if ((KnownNode == RootHash) && !Opts.AllowDownTraversalFromRo

[PATCH] D53317: [clangd] Allow disble down traversals from root.

2018-10-16 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. This is useful for symbo scope proximity, where down traversals from the global scope if not desired. Repository: rCTE Clang Tools Extr