[PATCH] D53295: Mark store and load of block invoke function as invariant.group

2019-07-04 Thread John McCall via Phabricator via cfe-commits
rjmccall added a reviewer: ahatanak. rjmccall added a comment. Herald added a subscriber: dexonsmith. Okay. Akira, do you have any interest in looking into this as a general block optimization? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53295/new/ https://reviews.llvm.org/D53295

[PATCH] D53295: Mark store and load of block invoke function as invariant.group

2019-07-04 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D53295#1561890 , @rjmccall wrote: > Great, thank you. Yaxun, are you planning to pick this back up? I know it's > been a long time. Sorry I caught up with some other work. Currently there has been another change about block

[PATCH] D53295: Mark store and load of block invoke function as invariant.group

2019-06-27 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. Great, thank you. Yaxun, are you planning to pick this back up? I know it's been a long time. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53295/new/ https://reviews.llvm.org/D53295 ___ cfe-commits mailing list

[PATCH] D53295: Mark store and load of block invoke function as invariant.group

2019-06-14 Thread Piotr Padlewski via Phabricator via cfe-commits
Prazek added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1318 +CGM.getModule().getMDKindID("invariant.load"), +llvm::MDNode::get(getLLVMContext(), None)); + rjmccall wrote: > yaxunl wrote: > > rjmccall wrote: > > > OpenCL blocks are stil

[PATCH] D53295: Mark store and load of block invoke function as invariant.group

2018-10-23 Thread John McCall via Phabricator via cfe-commits
rjmccall added a reviewer: Prazek. rjmccall added a comment. In https://reviews.llvm.org/D53295#1271590, @Anastasia wrote: > Btw, blocks w/o captures are already optimized into regular calls? That's a very easy optimization for the optimizer to do because the global can be marked constant.

[PATCH] D53295: Mark store and load of block invoke function as invariant.group

2018-10-22 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. Btw, blocks w/o captures are already optimized into regular calls? https://reviews.llvm.org/D53295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53295: Mark store and load of block invoke function as invariant.group

2018-10-16 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 169864. yaxunl retitled this revision from "[OpenCL] Mark load of block invoke function as invariant" to "Mark store and load of block invoke function as invariant.group". yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subsc