[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rC344765: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics (authored by mgrang, committed by ). Repository: rC Clang https://reviews.llvm.org/D53115 Files: include/clang/Basic/BuiltinsAA

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D53115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

mgrang updated this revision to Diff 170133. https://reviews.llvm.org/D53115 Files: include/clang/Basic/BuiltinsAArch64.def lib/CodeGen/CGBuiltin.cpp lib/Headers/intrin.h lib/Sema/SemaChecking.cpp test/CodeGen/arm64-microsoft-status-reg.cpp test/Sema/builtins-microsoft-arm64.c Index:

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

efriedma added inline comments. Comment at: lib/Sema/SemaChecking.cpp:1754 + // argument here. Any constant would be converted to a register of + // the form S1_2_C3_C4_5. Let the hardware throw an exception for incorrect + // registers. This matches MSVC behavior. ---

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

mgrang updated this revision to Diff 169127. https://reviews.llvm.org/D53115 Files: include/clang/Basic/BuiltinsAArch64.def lib/CodeGen/CGBuiltin.cpp lib/Headers/intrin.h lib/Sema/SemaChecking.cpp test/CodeGen/arm64-microsoft-status-reg.cpp test/Sema/builtins-microsoft-arm64.c Index:

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

efriedma added a comment. Missing Sema changes? Repository: rC Clang https://reviews.llvm.org/D53115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

mgrang added inline comments. Comment at: test/CodeGen/arm64-microsoft-status-reg.cpp:1 +// RUN: %clang_cc1 -triple arm64-windows -fms-compatibility -emit-llvm -S \ +// RUN: -o - %s | FileCheck %s -check-prefix CHECK-ASM I had to create a new test file here as th

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

mgrang added a comment. _ReadStatusReg and _WriteStatusReg intrinsics take ARM64_REGNO as input. These are defined in https://www.codemachine.com/downloads/win10/winnt.h. LLVM already has intrinsics to read/write status regs: __builtin_arm_rsr/__builtin_arm_wsr. But these take the string concate

[PATCH] D53115: [COFF, ARM64] Add _ReadStatusReg and_WriteStatusReg intrinsics

mgrang created this revision. mgrang added reviewers: rnk, compnerd, mstorsjo, efriedma, TomTan, haripul. Herald added a reviewer: javed.absar. Herald added subscribers: chrib, kristof.beyls. Repository: rC Clang https://reviews.llvm.org/D53115 Files: include/clang/Basic/BuiltinsAArch64.def