[PATCH] D53084: [clang-doc] Add unit tests for YAML

2018-10-16 Thread Julie Hockett via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344653: [clang-doc] Add unit tests for YAML generation (authored by juliehockett, committed by ). Changed prior to commit: https://reviews.llvm.org/D53084?vs=169751&id=169910#toc Repository: rCTE C

[PATCH] D53084: [clang-doc] Add unit tests for YAML

2018-10-15 Thread Jake Ehrlich via Phabricator via cfe-commits
jakehehrlich added a comment. This just seems like a lit test in unit test form, why does this need to use unit tests and not lit tests? https://reviews.llvm.org/D53084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D53084: [clang-doc] Add unit tests for YAML

2018-10-15 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett updated this revision to Diff 169751. juliehockett marked an inline comment as done. https://reviews.llvm.org/D53084 Files: clang-tools-extra/unittests/clang-doc/CMakeLists.txt clang-tools-extra/unittests/clang-doc/YAMLGeneratorTest.cpp Index: clang-tools-extra/unittests/clang-d

[PATCH] D53084: [clang-doc] Add unit tests for YAML

2018-10-15 Thread Petr Hosek via Phabricator via cfe-commits
phosek added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/YAMLGeneratorTest.cpp:45 + assert(!Err); + std::string Expected = + "---\n" Nit: use raw strings here as well, the same here below. https://reviews.llvm.org/D53084 ___

[PATCH] D53084: [clang-doc] Add unit tests for YAML

2018-10-10 Thread Julie Hockett via Phabricator via cfe-commits
juliehockett created this revision. juliehockett added reviewers: leonardchan, jakehehrlich, lebedev.ri. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. This is part of a move to convert clang-doc's tests to a more maintainable unit test framework, with a small