This revision was automatically updated to reflect the committed changes.
Closed by commit rL344245: [clangd] Remove no-op crash handler, we never set a
crash context. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
LGTM
> Of course the question arises: *should* we set one
Agree with your points. If the cleanup is unsafe, it might end up biting us
harder in the future.
Repository:
rCTE Clang Tools Ex
sammccall created this revision.
sammccall added reviewers: ioeric, ilya-biryukov.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
I think this was just copied from somewhere with the belief that it actually
did some crash handling.
Of course the question arises: *sho
