[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

sammccall added inline comments. Comment at: clangd/index/dex/dexp/Dexp.cpp:185 clang::clangd::LookupRequest Request; -Request.IDs = {*SID}; +Request.IDs.insert(IDs.begin(), IDs.end()); bool FoundSymbol = false; hokein wrote: > sammccall wrote:

[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344508: [clangd] dump xrefs information in dexp tool. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D53019?vs=169683&id=169684#toc Repository: rCTE Clang To

[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

hokein updated this revision to Diff 169683. hokein marked 3 inline comments as done. hokein added a comment. Fix global scope, and clang-format. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53019 Files: clangd/index/dex/dexp/CMakeLists.txt clangd/index/dex/dexp/Dexp.cpp

[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

hokein added inline comments. Comment at: clangd/index/dex/dexp/Dexp.cpp:61 + Request.Scopes.emplace_back(); + std::tie(Request.Scopes.back(), Request.Query) = + clang::clangd::splitQualifiedName(QualifiedName); sammccall wrote: > Are you sure you want bot

[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/dex/dexp/Dexp.cpp:61 + Request.Scopes.emplace_back(); + std::tie(Request.Scopes.back(), Request.Query) = + clang::clangd::splitQuali

[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

hokein updated this revision to Diff 169668. hokein marked 2 inline comments as done. hokein added a comment. Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53019 Files: clangd/index/dex/dexp/CMakeLists.txt clangd/index/dex/dexp/Dexp.cpp Index: cla

[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

sammccall added inline comments. Comment at: clangd/index/dex/dexp/Dexp.cpp:65 + clang::clangd::SymbolID SymID; + // We choose the first one if there are overloaded symbols. + Index->fuzzyFind(Request, [&](const Symbol &Sym) { I don't think this is reasonable

[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

hokein updated this revision to Diff 168802. hokein added a comment. Minor fix. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53019 Files: clangd/index/dex/dexp/CMakeLists.txt clangd/index/dex/dexp/Dexp.cpp Index: clangd/index/dex/dexp/Dexp.cpp ===

[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

hokein added inline comments. Comment at: clangd/index/dex/dexp/Dexp.cpp:204 {"lookup", "Dump symbol details by ID", llvm::make_unique}, +{"refs", "Find references by qualified name", llvm::make_unique}, }; sammccall wrote: > I'm not sure "by qualified

[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

hokein updated this revision to Diff 168801. hokein marked 3 inline comments as done. hokein added a comment. Herald added a subscriber: mgorny. Address review comments: - provide query by qualified name (with -name) - add -name support for Lookup. Repository: rCTE Clang Tools Extra https://

[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

sammccall added inline comments. Comment at: clangd/index/dex/dexp/Dexp.cpp:172 + "filter", cl::init(".*"), + cl::desc("Print all results from files matching this filter."), + }; filter -> regular expression Comment at: clangd/index/

[PATCH] D53019: [clangd] dump xrefs information in dexp tool.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53019 Files: clangd/index/dex/dexp/Dexp.cpp Index: clangd/index/dex/dexp/De