This revision was automatically updated to reflect the committed changes.
Closed by commit rL344033: [clangd] Mark colon as a safe character when
percent-encoding. (authored by kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D5301
kadircet updated this revision to Diff 168771.
kadircet added a comment.
- Add comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53016
Files:
clangd/URI.cpp
unittests/clangd/URITests.cpp
Index: unittests/clangd/URITests.cpp
=
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/URI.cpp:94
case '/': // '/' is only reserved when parsing.
+ case ':':
return false;
add a comment: ':' is only reserve
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
Also change output of percent-encoding to use upper-case letters.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53016