This revision was automatically updated to reflect the committed changes.
Closed by commit rC347888: [analyzer][PlistMacroExpansion] Part 4.: Support for
__VA_ARGS__ (authored by Szelethus, committed by ).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52986/new/
h
Szelethus marked 2 inline comments as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:884
+ // even if we lex a tok::comma and ParanthesesDepth == 1.
+ const IdentifierInfo *__VA_ARGS__II = PP.getIdentifierInfo("__VA_ARGS__");
+
-
Szelethus marked 2 inline comments as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:884
+ // even if we lex a tok::comma and ParanthesesDepth == 1.
+ const IdentifierInfo *__VA_ARGS__II = PP.getIdentifierInfo("__VA_ARGS__");
+
-
Szelethus updated this revision to Diff 175718.
Szelethus added a comment.
Herald added a subscriber: gamesh411.
- Fixed a crash where no arguments (**not** empty arguments) were supplied to
`__VA_ARGS__`.
- Rebased to master.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52986/new/
ht
xazax.hun accepted this revision.
xazax.hun added a comment.
One question otherwise looks good.
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:884
+ // even if we lex a tok::comma and ParanthesesDepth == 1.
+ const IdentifierInfo *__VA_ARGS__II = PP.getIdentifierInf
NoQ accepted this revision.
NoQ added a comment.
> haha!
:D
https://reviews.llvm.org/D52986
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus updated this revision to Diff 169869.
Szelethus added a comment.
Herald added a subscriber: dkrupp.
Rebased to part 3.
https://reviews.llvm.org/D52986
Files:
lib/StaticAnalyzer/Core/PlistDiagnostics.cpp
test/Analysis/Inputs/expected-plists/plist-macros-with-expansion.cpp.plist
t
Szelethus created this revision.
Szelethus added reviewers: george.karpenkov, xazax.hun, NoQ, rnkovacs,
baloghadamsoftware.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
Thanks to @donat.nagy for spotting this!
Repository:
rC Clang
https://reviews.ll
