NoQ closed this revision.
NoQ added a comment.
Herald added subscribers: dkrupp, donat.nagy.
I committed both patches as https://reviews.llvm.org/rC344823 but it seems that
Phabricator doesn't pick up closing multiple revisions with the same commit, so
closing manually.
Also thanks!~
Reposito
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yup, this one looks great as well. I'll commit. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D52906
___
cfe-commits mailing list
cfe-commit
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/Checker.cpp:20
+int ImplicitNullDerefEvent::Tag;
+
Szelethus wrote:
> nit: Static fields initialize to 0 without out of line definition.
Never mind, you still have to define it. It's been a wh
Szelethus added a comment.
Please reupload with full context (`-U`).
Comment at: lib/StaticAnalyzer/Core/Checker.cpp:20
+int ImplicitNullDerefEvent::Tag;
+
nit: Static fields initialize to 0 without out of line definition.
Repository:
rC Clang
https:
