[PATCH] D52905: [analyzer] fix accessing GDM data from shared libraries

2018-10-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL344823: [analyzer] Be more plugin-friendly by moving static locals into .cpp files. (authored by dergachev, committed by ). Herald added subscribers: llvm-commits, dkrupp, donat.nagy. Changed prior to com

[PATCH] D52905: [analyzer] fix accessing GDM data from shared libraries

2018-10-09 Thread George Karpenkov via Phabricator via cfe-commits
george.karpenkov added a comment. > there's a way to run clang-tidy over all of clang+llvm automatically cmake should generate compile_commands.json by default, and then you could just point clang-tidy at that. Repository: rC Clang https://reviews.llvm.org/D52905

[PATCH] D52905: [analyzer] fix accessing GDM data from shared libraries

2018-10-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. In https://reviews.llvm.org/D52905#1259249, @NoQ wrote: > > where `isStaticLocal` is defined as: > > You can send this one as well if you like! It's weird that we don't already > have it. Or actually maybe it can be implemented as `allOf(hasStaticStorageDuration(), unless

[PATCH] D52905: [analyzer] fix accessing GDM data from shared libraries

2018-10-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. > where `isStaticLocal` is defined as: You can send this one as well if you like! It's weird that we don't already have it. Repository: rC Clang https://reviews.llvm.org/D52905 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D52905: [analyzer] fix accessing GDM data from shared libraries

2018-10-09 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Cool, thanks! I'll commit. Repository: rC Clang https://reviews.llvm.org/D52905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

[PATCH] D52905: [analyzer] fix accessing GDM data from shared libraries

2018-10-09 Thread Joe Ranieri via Phabricator via cfe-commits
jranieri-grammatech updated this revision to Diff 168815. jranieri-grammatech added a comment. Added more context. Repository: rC Clang https://reviews.llvm.org/D52905 Files: include/clang/StaticAnalyzer/Core/PathSensitive/DynamicTypeMap.h include/clang/StaticAnalyzer/Core/PathSensitive/

[PATCH] D52905: [analyzer] fix accessing GDM data from shared libraries

2018-10-09 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. Please reupload with full context (`-U9`). Repository: rC Clang https://reviews.llvm.org/D52905 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits