This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.
Closed by commit rCTE343777: [clangd] Remove one-segment-skipping from Dex
trigrams. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D5
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clangd/index/dex/Trigram.cpp:44
// * Next Head - front character of the next segment
// * Skip-1-Next Head - front character of the skip-1-next segment
sammccall created this revision.
sammccall added reviewers: ilya-biryukov, ioeric.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay.
Currently queries like "ab" can match identifiers like a_yellow_bee.
The value of allowing this for exactly one segment but no more seems
