This revision was automatically updated to reflect the committed changes.
Closed by commit rL343841: [clangd] Make binary index format the default,
remove dead flag. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
sammccall marked an inline comment as done.
sammccall added inline comments.
Comment at: clangd/indexer/IndexerMain.cpp:58
SymbolCollector::Options Opts;
-Opts.FallbackDir = AssumedHeaderDir;
return createStaticIndexingAction(
hokein wrote:
> If we
sammccall updated this revision to Diff 168287.
sammccall added a comment.
example filename "clangd.dex"
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52872
Files:
clangd/indexer/IndexerMain.cpp
Index: clangd/indexer/IndexerMain.cpp
sammccall added inline comments.
Comment at: clangd/indexer/IndexerMain.cpp:84
- $ clangd-indexer --executor=all-TUs compile_commands.json > index.yaml
+ $ clangd-indexer --executor=all-TUs compile_commands.json > clangd-index
hokein wrote:
> ilya-biryukov
hokein added inline comments.
Comment at: clangd/indexer/IndexerMain.cpp:58
SymbolCollector::Options Opts;
-Opts.FallbackDir = AssumedHeaderDir;
return createStaticIndexingAction(
If we remove the `assume-header-dir`, we probably remove `FallbackDir
ilya-biryukov added inline comments.
Comment at: clangd/indexer/IndexerMain.cpp:84
- $ clangd-indexer --executor=all-TUs compile_commands.json > index.yaml
+ $ clangd-indexer --executor=all-TUs compile_commands.json > clangd-index
Maybe we should suggest a
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52872
Files:
clangd/indexer/IndexerMain.cpp
Index: clangd/i
