steveire updated this revision to Diff 170310.
steveire added a comment.
Don't deprecate existing API
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests
steveire added a comment.
Perhaps the best solution is to introduce this new API, but not deprecate the
existing 'exclusive' API.
What do you think?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
___
cfe-commits mailing list
steveire updated this revision to Diff 170308.
steveire added a comment.
Update test
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests/clang-query/Quer
steveire updated this revision to Diff 170306.
steveire added a comment.
Fix test
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests/clang-query/QueryEn
steveire updated this revision to Diff 170305.
steveire added a comment.
Fix tests
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests/clang-query/QueryE
steveire updated this revision to Diff 170304.
steveire added a comment.
Rename dump-output to ast-output.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unit
aaron.ballman added a comment.
@steveire and I chatted over IRC and I wanted to capture another alternate
proposal idea as part of the review (we did not reach agreement on this
proposal, however). I've provided it side-by-side with the other proposals for
comparison purposes.
# Original pro
steveire added a comment.
> I don't see this functionality being so critical that we need to deprecate
> the existing spelling when there are backwards compatible options available,
> which is why I'm opposed to this patch going in with the proposed syntax.
I don't think we're going to go anywh
aaron.ballman added a comment.
In https://reviews.llvm.org/D52857#1260455, @steveire wrote:
> > you have to find the right place to stick the `set dump-output true` in
> > order to enable it.
>
> What do you mean "the right place"?
The point from which they want to enable dump outputting.
steveire added a comment.
> you have to find the right place to stick the `set dump-output true` in
> order to enable it.
What do you mean "the right place"?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
___
cfe-commits m
aaron.ballman added a comment.
In https://reviews.llvm.org/D52857#1259522, @steveire wrote:
> > What's more, given that clang-output has no real documentation to speak of,
> > how will users even *know* to update their scripts?
>
> The release notes will tell them.
That's not user friendly.
>
steveire added a comment.
> What's more, given that clang-output has no real documentation to speak of,
> how will users even *know* to update their scripts?
The release notes will tell them.
But your comment also raises a different point: If there is so little
clang-query documentation, what
aaron.ballman added a comment.
In https://reviews.llvm.org/D52857#1258893, @steveire wrote:
> - The scripts will continue to work at least until `set output` is removed,
> which is not going to happen soon.
Certainly, but given that deprecation implies eventual removal, people are
still being
steveire added a comment.
- The scripts will continue to work at least until `set output` is removed,
which is not going to happen soon.
- A comma-delimited list of options means that if I have `foo, bar, bat`
enabled and want to add `bang`, I need to `set output foo, bar, bat, bang`. Or
alter
aaron.ballman added a comment.
I'm not all that keen on the idea of deprecating `set output` like this -- that
command has been around since forever, and scripts outside of our control are
likely to rely on it. However, it seems like you should be able to make `set
output` accept a comma-delimi
steveire added a comment.
Can I convince someone to be interested enough in this to approve it?
I have a talk coming up and I'd like to be able to say that you don't have to
switch between `dump` mode and `diag` mode all the time.
I also want to enable other relevant outputting features in `cla
steveire added inline comments.
Comment at: clang-query/Query.cpp:48
+"Set whether to dump binding ASTs.\n"
+" set print-output (true|false) "
+"Set whether to print matched text.\n"
Is the 'print' output useful at all? I'm thinking
steveire updated this revision to Diff 168218.
steveire added a comment.
Commit message
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests/clang-query/Q
steveire updated this revision to Diff 168217.
steveire added a comment.
Format
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52857
Files:
clang-query/Query.cpp
clang-query/Query.h
clang-query/QueryParser.cpp
clang-query/QuerySession.h
unittests/clang-query/QueryEngi
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
Replace it with granular options.
This makes it possible to
- Have both diag and dump active at once
- Extend the output with other queryable content in the future.
Repository:
r
20 matches
Mail list logo
