[PATCH] D52853: [Analyzer] Try fixing ConstraintManager::assumeDual

MaskRay abandoned this revision. MaskRay added a comment. Thanks for your prompt response https://reviews.llvm.org/rC343747 . I'll abandon this revision! Repository: rC Clang https://reviews.llvm.org/D52853 ___ cfe-commits mailing list cfe-commi

[PATCH] D52853: [Analyzer] Try fixing ConstraintManager::assumeDual

george.karpenkov added a comment. Tracked in rdar://44992170. Marking the test as unsupported for now. Repository: rC Clang https://reviews.llvm.org/D52853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D52853: [Analyzer] Try fixing ConstraintManager::assumeDual

NoQ added a comment. *reads the comments* no, NDEBUG won't work. Ok, we'll take care of this, thanks! Repository: rC Clang https://reviews.llvm.org/D52853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D52853: [Analyzer] Try fixing ConstraintManager::assumeDual

NoQ added a comment. And, of course, we'll need to change `__OPTIMIZE__` to `NDEBUG`. Also thanks for reporting the problem! Repository: rC Clang https://reviews.llvm.org/D52853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D52853: [Analyzer] Try fixing ConstraintManager::assumeDual

NoQ added a comment. Hmm, wait, right, i might have an idea of what's going on. I think we need to revert. Repository: rC Clang https://reviews.llvm.org/D52853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D52853: [Analyzer] Try fixing ConstraintManager::assumeDual

MaskRay added a comment. In https://reviews.llvm.org/D52853#1254486, @NoQ wrote: > This should have been fixed by https://reviews.llvm.org/D52848. > > This is a very important fundamental assertion, we definitely should not > remove it. Sorry I don't understand the code at all but I get a diff

[PATCH] D52853: [Analyzer] Try fixing ConstraintManager::assumeDual

NoQ added a comment. This should have been fixed by https://reviews.llvm.org/D52848. This is a very important fundamental assertion, we definitely should not remove it. Repository: rC Clang https://reviews.llvm.org/D52853 ___ cfe-commits mailin

[PATCH] D52853: [Analyzer] Try fixing ConstraintManager::assumeDual

MaskRay created this revision. MaskRay added reviewers: NoQ, george.karpenkov, dcoughlin. Herald added subscribers: cfe-commits, Szelethus, mikhail.ramalho, a.sidorin, JDevlieghere, szepet, xazax.hun. This fixes test/Analysis/trustnonnullchecker_test.m in Debug mode. Repository: rC Clang htt