This revision was automatically updated to reflect the committed changes.
Closed by commit rL343665: Allow comments with '#' in dynamic AST
Matchers (authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52751?vs=167987
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some naming and style convention nits, LGTM.
Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:151
Sema.parse(" Foo ( Bar ( 17), Baz( \n \"
steveire marked an inline comment as done.
steveire added inline comments.
Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:188-190
+ for (size_t i = 0, e = Sema.Errors.size(); i != e; ++i) {
+EXPECT_EQ("", Sema.Errors[i]);
+ }
aaron.ballman wrote:
steveire updated this revision to Diff 167987.
steveire added a comment.
use cxx_range_for
Repository:
rC Clang
https://reviews.llvm.org/D52751
Files:
lib/ASTMatchers/Dynamic/Parser.cpp
unittests/ASTMatchers/Dynamic/ParserTest.cpp
Index: unittests/ASTMatchers/Dynamic/ParserTest.cpp
===
aaron.ballman added inline comments.
Comment at: unittests/ASTMatchers/Dynamic/ParserTest.cpp:188-190
+ for (size_t i = 0, e = Sema.Errors.size(); i != e; ++i) {
+EXPECT_EQ("", Sema.Errors[i]);
+ }
Why are empty errors created? I would have expected this to
steveire created this revision.
steveire added a reviewer: aaron.ballman.
Herald added a subscriber: cfe-commits.
This is necessary for clang-query to be able to handle comments.
Repository:
rC Clang
https://reviews.llvm.org/D52751
Files:
lib/ASTMatchers/Dynamic/Parser.cpp
unittests/ASTM
