[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

2018-10-03 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE343664: [clang-query] Add single-letter 'q' alias for 'quit' (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D52746?vs=167984&id=168077#toc Repository: rCTE

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

2018-10-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

2018-10-02 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. In https://reviews.llvm.org/D52746#1252455, @aaron.ballman wrote: > Please update `HelpQuery::run()` to print out the new mnemonic (it's the > *only* form of public documentation we have for clang-query currently). Good point, thanks! Repository: rCTE Clang Tools

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

2018-10-02 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 167984. steveire added a comment. Add docs Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 Files: clang-query/Query.cpp clang-query/QueryParser.cpp unittests/clang-query/QueryParserTest.cpp Index: unittests/clang-query/QueryPa

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

2018-10-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Please update `HelpQuery::run()` to print out the new mnemonic (it's the *only* form of public documentation we have for clang-query currently). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 __

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

2018-10-02 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. @Szelethus You can approve it and then you will get the feature :). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

2018-10-01 Thread Umann Kristóf via Phabricator via cfe-commits
Szelethus added a comment. I'd personally really enjoy this feature. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

2018-10-01 Thread Stephen Kelly via Phabricator via cfe-commits
steveire updated this revision to Diff 167825. steveire added a comment. Add test Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 Files: clang-query/QueryParser.cpp unittests/clang-query/QueryParserTest.cpp Index: unittests/clang-query/QueryParserTest.cpp ===

[PATCH] D52746: [clang-query] Add single-letter 'q' alias for 'quit'

2018-10-01 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added reviewers: alexfh, aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52746 Files: clang-query/QueryParser.cpp Index: clang-query/QueryParser.cpp