[PATCH] D52710: [clangd] Add "check-clangd" target

This revision was automatically updated to reflect the committed changes. Closed by commit rL343474: [clangd] Add "check-clangd" target (authored by hokein, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D52710 Files: clang-tools-extra/

[PATCH] D52710: [clangd] Add "check-clangd" target

hokein added a comment. Need someone stamps on https://reviews.llvm.org/D52713 before landing this patch :) Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D52710: [clangd] Add "check-clangd" target

ilya-biryukov added a comment. This is awesome! Can't wait for it to land! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D52710: [clangd] Add "check-clangd" target

sammccall accepted this revision. sammccall added a comment. Awesome, thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D52710: [clangd] Add "check-clangd" target

hokein updated this revision to Diff 167692. hokein added a comment. Remove llvm util dependencies (we move it to add_lit_target(). Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52710 Files: test/CMakeLists.txt Index: test/CMakeLists.txt ===

[PATCH] D52710: [clangd] Add "check-clangd" target

sammccall added inline comments. Comment at: test/CMakeLists.txt:76 -set(llvm_utils - FileCheck count not - ) - -foreach(t ${llvm_utils}) - if(TARGET ${t}) -list(APPEND CLANG_TOOLS_TEST_DEPS ${t}) - endif() -endforeach() - +macro(add_llvm_utils_deps deps) + set(llvm_ut

[PATCH] D52710: [clangd] Add "check-clangd" target

hokein added inline comments. Comment at: test/CMakeLists.txt:76 -set(llvm_utils - FileCheck count not - ) - -foreach(t ${llvm_utils}) - if(TARGET ${t}) -list(APPEND CLANG_TOOLS_TEST_DEPS ${t}) - endif() -endforeach() - +macro(add_llvm_utils_deps deps) + set(llvm_utils

[PATCH] D52710: [clangd] Add "check-clangd" target

hokein updated this revision to Diff 167689. hokein marked 2 inline comments as done. hokein added a comment. Remove clangd-binary dep in check-clang-tools, and use check-clangd. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52710 Files: test/CMakeLists.txt Index: test/CMa

[PATCH] D52710: [clangd] Add "check-clangd" target

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome! Please do remove that duplication if it's easy. Comment at: test/CMakeLists.txt:36 set(CLANG_TOOLS_TEST_DEPS # For the clang-apply-replacements test that

[PATCH] D52710: [clangd] Add "check-clangd" target

hokein marked an inline comment as done. hokein added inline comments. Comment at: test/CMakeLists.txt:36 set(CLANG_TOOLS_TEST_DEPS # For the clang-apply-replacements test that uses clang-rename. sammccall wrote: > can we add all of clangd to this list with

[PATCH] D52710: [clangd] Add "check-clangd" target

sammccall added a comment. Thanks for doing this! Sorry for the dumb questions, I don't get cmake. Comment at: test/CMakeLists.txt:36 set(CLANG_TOOLS_TEST_DEPS # For the clang-apply-replacements test that uses clang-rename. can we add all of clangd to thi

[PATCH] D52710: [clangd] Add "check-clangd" target

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. So we don't have to run "check-clang-tools" (which builds and tests all clang tools) to verify our clangd-related change. It'd save wait