[PATCH] D52696: Update ifunc attribute support documentation

2018-09-30 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. Yeah, I would restrict it to just mention that it depends on the target, link time editor and runtime linker. Even the concrete feature set on Linux changes with glibc versions. Repository: rL LLVM https://reviews.llvm.org/D52696 ___

[PATCH] D52696: Update ifunc attribute support documentation

2018-09-30 Thread Ed Maste via Phabricator via cfe-commits
emaste added a comment. Maybe "available for some architectures in at least..."? Or maybe we shouldn't bother trying to list versions, and mention it is dependent on CPU arch, linker, and rtld? Repository: rL LLVM https://reviews.llvm.org/D52696 __

[PATCH] D52696: Update ifunc attribute support documentation

2018-09-30 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added a comment. I think this is still too optimistic. Full support for ifunc seems to be generally limited to x86. Most other architectures lack even definitions for anonymous ifunc relocations or support proper relaxation only in limited forms. That's especially annoying when looking at

[PATCH] D52696: Update ifunc attribute support documentation

2018-09-30 Thread Ed Maste via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL343408: Update ifunc attribute support documentation (authored by emaste, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52696?vs=167626&id=1

[PATCH] D52696: Update ifunc attribute support documentation

2018-09-30 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D52696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D52696: Update ifunc attribute support documentation

2018-09-29 Thread Ed Maste via Phabricator via cfe-commits
emaste created this revision. emaste added a reviewer: DmitryPolukhin. Herald added a subscriber: krytarowski. We documented GNU binutils and glibc versions required for ifunc support, but our own lld linker and FreeBSD's rtld also support ifuncs. https://reviews.llvm.org/D52696 Files: inclu