This revision was automatically updated to reflect the committed changes.
Closed by commit rL344285: [HIP] Remove unused irif bitcode from test (authored
by aaronenyeshi, committed by ).
Herald added subscribers: llvm-commits, jvesely.
Changed prior to commit:
https://reviews.llvm.org/D52673?vs
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D52673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
ashi1 updated this revision to Diff 168855.
ashi1 marked an inline comment as done.
ashi1 added a comment.
I've moved the hip.amdgcn.bc to the top of the libs. Updated test as well.
https://reviews.llvm.org/D52673
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/hip-device-libs.hip
Index:
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/HIP.cpp:85
C.addTempFile(C.getArgs().MakeArgString(TmpName));
CmdArgs.push_back(OutputFileName);
SmallString<128> ExecPath(C.getDriver().Dir);
maybe we should put hip.amdgcn.bc at the be
ashi1 updated this revision to Diff 168836.
ashi1 added a comment.
The device libraries has been updated, and the hip.amdgcn.bc library is now
available there.
Repository:
rC Clang
https://reviews.llvm.org/D52673
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/hip-device-libs.hip
Ind
ashi1 added a comment.
I've added a hip.amdgcn.bc library for the fence functions that were originally
in irif library.
https://reviews.llvm.org/D52673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
ashi1 updated this revision to Diff 168384.
ashi1 edited the summary of this revision.
Herald added a subscriber: jfb.
https://reviews.llvm.org/D52673
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/hip-device-libs.hip
Index: test/Driver/hip-device-libs.hip
ashi1 updated this revision to Diff 167741.
ashi1 added a comment.
Added diff with full context. Also, I need to find replacements for few
functions in HIP github before this can be submitted.
https://reviews.llvm.org/D52673
Files:
lib/Driver/ToolChains/HIP.cpp
test/Driver/hip-device-libs.
yaxunl added a comment.
this seems to be duplicate of https://reviews.llvm.org/D51857
Is HIP github ready for this change?
Repository:
rC Clang
https://reviews.llvm.org/D52673
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.
kristina added a comment.
If you don't mind, can you please do another revision with full context
(`-U9`), makes it easier to review and makes it less likely that `svn
patch` screws up.
Repository:
rC Clang
https://reviews.llvm.org/D52673
_
ashi1 created this revision.
ashi1 added reviewers: yaxunl, b-sumner, scchan.
Herald added a subscriber: cfe-commits.
Device Libraries has removed irif.amdgcn.bc, so we need to remove this
requirement from HIP Toolchains. Also a few header functions need to be updated.
Repository:
rC Clang
h
11 matches
Mail list logo
