This revision was automatically updated to reflect the committed changes.
Closed by commit rL343937: [clangd] NFC: Migrate to LLVM STLExtras API where
possible (authored by omtcyfz, committed by ).
Herald added subscribers: llvm-commits, kristina.
Changed prior to commit:
https://reviews.llvm.o
kbobyrev updated this revision to Diff 168589.
kbobyrev added a comment.
Rebase on top of HEAD.
https://reviews.llvm.org/D52650
Files:
clang-tools-extra/clangd/ClangdLSPServer.cpp
clang-tools-extra/clangd/ClangdServer.cpp
clang-tools-extra/clangd/CodeComplete.cpp
clang-tools-extra/clang
kbobyrev added a comment.
In https://reviews.llvm.org/D52650#1249556, @sammccall wrote:
> I think it's fine to update others too, this is a trivially-safe change and
> a nice readability improvement.
> No need to put everything in the same patch though.
Great, thanks! I'll submit the patch on
sammccall added subscribers: ioeric, kbobyrev.
sammccall added a comment.
I think it's fine to update others too, this is a trivially-safe change and
a nice readability improvement.
No need to put everything in the same patch though.
https://reviews.llvm.org/D52650
___
I think it's fine to update others too, this is a trivially-safe change and
a nice readability improvement.
No need to put everything in the same patch though.
On Fri, Sep 28, 2018, 16:23 Kirill Bobyrev via Phabricator <
revi...@reviews.llvm.org> wrote:
> kbobyrev added a comment.
>
> Also, I'm n
kbobyrev added a comment.
Also, I'm not sure whether I should update Clang-Tidy and other tools in the
scope of this patch. It makes sense to me, but I don't know whether the
maintainers of these projects are happy with the change. WDYT?
https://reviews.llvm.org/D52650
_
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, dexonsmith, mgrang, jkorous,
MaskRay, javed.absar, ilya-biryukov.
This patch improves readability by migrating `std::function(For
