sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
The implementation looks fine, but I believe we concluded that seeing huge
lists here was basically a bug.
So you may not want to land it, if you prefer to keep things simple. Up to you.
ioeric updated this revision to Diff 167361.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- simplify the code.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52617
Files:
clangd/CodeComplete.cpp
Index: clangd/CodeComplete.cpp
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:325
+CodeCompletion::IncludeCandidates
+moveNonInsertingIncludesToFront(CodeCompletion::IncludeCandidates Includes) {
+ if (Includes.size() <= 1)
this seems a bit overly complicated. It does se
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
stable_partition on objects is slow (due to copies). Do it on pointers
instead.
Repository:
rCTE Clang Tools Extra
https://reviews.llv
