This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343237: Introduce completionItemKind capability support.
(authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52616?vs=167346&id=167347#toc
Repository:
rCTE Cla
kadircet updated this revision to Diff 167346.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52616
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Protocol.cpp
cl
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/ClangdLSPServer.cpp:108
+ if (Params.capabilities.textDocument.completion.completionItemKind)
+for (CompletionItemKind Kind : *Params.capabi
kadircet updated this revision to Diff 167332.
kadircet added a comment.
- Minimum CompletionItemKind is Text.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52616
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Protocol.cpp
clangd/Protocol.h
Index: c
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52616
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Prot
