[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2019-03-10 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski resigned from this revision. krytarowski added a comment. Herald added a project: clang. ESan is now discontinued. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52610/new/ https://reviews.llvm.org/D52610

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2019-01-06 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. Can you try to port this mutant thread-process in ESan to FreeBSD? I don't want to see changes in generic LLVM code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52610/new/ https://reviews.llvm.org/D52610

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-29 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. Things might differ between NetBSD and FreeBSD about the feasibility. So maybe for the former it is more reachable (only would need to set specific application mappings maybe ?). - So once the non writable addresses are created, it processes the working sets to make i

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-29 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. In https://reviews.llvm.org/D52610#1279176, @devnexen wrote: > - FreeBSD does not have real Linux's clone equivalent. > - Hangs or crashes during the final report (the shadow mapping is similar as > Linux's though). NetBSD has a clone compatibility syscall... but p

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-29 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. - FreeBSD does not have real Linux's clone equivalent. - Hangs or crashes during the final report (the shadow mapping is similar as Linux's though). Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits m

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-29 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. In https://reviews.llvm.org/D52610#1278743, @devnexen wrote: > ping working-set on FreeBSD does not seem doable. Rationale? I don't feel convinced. Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commi

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-29 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping working-set on FreeBSD does not seem doable. Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-10 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:323 Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag; - else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet)) + else if (T.getOS() == Triple::Linux && +LangOpts.Sanitize.ha

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-10 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:323 Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag; - else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet)) + else if (T.getOS() == Triple::Linux && +LangOpts.Sanitize

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-10 Thread David CARLIER via Phabricator via cfe-commits
devnexen added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:323 Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag; - else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet)) + else if (T.getOS() == Triple::Linux && +LangOpts.Sanitize.ha

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-09 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added inline comments. Comment at: lib/CodeGen/BackendUtil.cpp:323 Opts.ToolType = EfficiencySanitizerOptions::ESAN_CacheFrag; - else if (LangOpts.Sanitize.has(SanitizerKind::EfficiencyWorkingSet)) + else if (T.getOS() == Triple::Linux && +LangOpts.Sanitize

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-08 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping. Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-04 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping compiler-rt component committed :-) Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

2018-10-01 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. The compiler-rt part had been committed. Repository: rC Clang https://reviews.llvm.org/D52610 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits