This revision was automatically updated to reflect the committed changes.
Closed by commit rC343808: [AST] Revert mangling changes from r339428 (authored
by smeenai, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52581?vs=167219&id=168354#toc
Repository:
rC Clang
https:/
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
I think going back to the old mangling makes sense.
Regarding memory management, I assume that the C++ code is just forward
declaring objective C class and interface types so it can pass them around
smeenai added a comment.
https://reviews.llvm.org/D52674 adds the RTTI Obj-C discriminator. I put it up
as a separate change so it could be reviewed independently and more thoroughly.
Repository:
rC Clang
https://reviews.llvm.org/D52581
___
cfe-
theraven added a comment.
In https://reviews.llvm.org/D52581#1248306, @smeenai wrote:
> The simplest option is something like https://reviews.llvm.org/P8109, where
> we add a `.objc` discriminator when mangling the RTTI itself. It would
> require the GNUStep runtime for Windows to be altered ac
smeenai added a subscriber: rnk.
smeenai added a comment.
Adding @rnk, since this'll touch MS ABI mangling. For context, we want `struct
X` to have the same mangling as `@interface X` normally, but we want to be able
to distinguish them for the purpose of exception handling. See this diff's
sum
smeenai added a comment.
In https://reviews.llvm.org/D52581#1247409, @theraven wrote:
> > I would have done the same for the GNUstep RTTI here, except I don't
> > actually
> > see the code for that anywhere, and no tests seem to break either, so I
> > believe it's not upstreamed yet.
>
> I'm n
theraven added a comment.
> I would have done the same for the GNUstep RTTI here, except I don't actually
> see the code for that anywhere, and no tests seem to break either, so I
> believe it's not upstreamed yet.
I'm not sure I understand this comment. The compiler code is in LLVM and the
t
smeenai created this revision.
smeenai added reviewers: compnerd, rjmccall, theraven, DHowett-MSFT.
As discussed in https://reviews.llvm.org/D50144, we want Obj-C classes
to have the same mangling as C++ structs, to support headers like the
following:
#ifdef __OBJC__
@class I;
#else
struc
