lebedev.ri added inline comments.
Comment at: test/clang-tidy/misc-class-inherit-from-struct.cpp:13
+};
+
+class C
lebedev.ri wrote:
> Missing cases:
> * struct inheriting from struct
> * Different inheritance visibility:
> * You only check the default visibili
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:109
+- New :doc:`misc-class-inherit-from-struct
+ ` check.
Please use alphabetical order for new checks list.
Comment at: docs/clang-tidy/checks/misc-class-inherit-from-
aaron.ballman added a comment.
This strikes me as likely being a very chatty diagnostic. For instance, it will
trigger on harmless code that uses empty base class optimization (in addition
to other concerns pointed out by @lebedev.ri). It seems like the real concern
here is unintentional inform
lebedev.ri added a comment.
Please upload patches with full context.
Please do follow coding style, clang-format your patches.
Would it make sense to not catch-all all the `class : struct`, but consider the
explicitly specified inheritance visibility?
Comment at: clang-tidy/m
DennisMelamed created this revision.
DennisMelamed added reviewers: alexfh, aaron.ballman, hokein, JonasToth.
Herald added subscribers: xazax.hun, mgorny.
[clang-tidy] Flag Classes Inheriting From Structs
Added a check which flags cases of a class inheriting from a struct, which can
cause uninte
