This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE343221: Tell whether file/folder for include completions.
(authored by kadircet, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52547?vs=167320&id=167321#toc
Repository:
rCTE Cl
kadircet updated this revision to Diff 167320.
kadircet marked 2 inline comments as done.
kadircet added a comment.
Preparing the patch to respect client capabilities.
- Add other itemkinds as well.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52547
Files
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D52547#1247794, @kadircet wrote:
> In https://reviews.llvm.org/D52547#1246701, @ilya-biryukov wrote:
>
> > A drive-by comment.
> > Would it be cleaner to pass
kadircet added a comment.
In https://reviews.llvm.org/D52547#1246701, @ilya-biryukov wrote:
> A drive-by comment.
> Would it be cleaner to pass this information from clang? Relying on
> completion label seems shaky.
Actually I also wanted to do that at first, but then wasn't really sure wheth
ilya-biryukov added a comment.
A drive-by comment.
Would it be cleaner to pass this information from clang? Relying on completion
label seems shaky.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52547
___
cfe-commits mailing list
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric, ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52547
Files:
clangd/CodeComplete.cpp
clangd/Protocol.h
unittests/clangd/Code
