This revision was automatically updated to reflect the committed changes.
Closed by commit rL343197: Improve diagnostics range reporting. (authored by
kadircet, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52544
Files:
clang-tools-ex
kadircet added inline comments.
Comment at: unittests/clangd/ClangdUnitTests.cpp:82
o]]();
- foo()$semicolon[[]]
+ foo()$semicolon[[]]//with comments
$unk[[unknown]]();
ioeric wrote:
> What is this `//with comments` for? Maybe explain it in the
kadircet updated this revision to Diff 167283.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52544
Files:
clangd/Diagnostics.cpp
unittests/clangd/ClangdUnitTests.cpp
Index: unittests
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/Diagnostics.cpp:55
// Accept the first range that contains the location.
+ llvm::Optional PossibleRange;
for (const auto &CR : D.getRanges()) {
kadircet created this revision.
kadircet added reviewers: sammccall, ioeric.
Herald added subscribers: cfe-commits, arphaman, jkorous, ilya-biryukov.
If we have some range information coming from clang diagnostic, promote
that one even if it doesn't contain diagnostic location inside.
Repository
