Szelethus added inline comments.
Comment at:
cfe/trunk/lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h:82-84
+ // TODO: This destructor shouldn't be virtual, but breaks buildbots with
+ // -Werror -Wnon-virtual-dtor.
+ virtual ~FieldNode() = default;
---
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343204: [Lex] TokenConcatenation now takes const
Preprocessor (authored by Szelethus, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52502?vs
Szelethus added a comment.
Thanks!
> any particular motivation for this?
I'm currently trying to include macro expansions in the Static Analyzer's plist
output, and I only managed to make this happen by some `Token` handling
hackery, including printing them. I saw this trick in
`lib/Rewrite/H
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
any particular motivation for this? But looks fine to me in any case.
Repository:
rC Clang
https://reviews.llvm.org/D52502
___
cfe-commits
Szelethus created this revision.
Szelethus added a reviewer: dblaikie.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D52502
Files:
include/clang/Lex/TokenConcatenation.h
lib/Lex/TokenConcatenation.cpp
Index: lib/Lex/TokenConcatenation.cpp
=
