ioeric updated this revision to Diff 166839.
ioeric added a comment.
- lower case function name.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52455
Files:
clangd/URI.cpp
unittests/clangd/URITests.cpp
Index: unittests/clangd/URITests.cpp
=
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE342961: [clangd] Check that scheme is valid when parsing
URI. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52455?vs=166839&id=166840#toc
Repository:
rCTE
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/URI.cpp:134
+static bool IsValidScheme(llvm::StringRef Scheme) {
+ if (Scheme.empty())
nit: lowercase isValidScheme
Reposit
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ilya-biryukov.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52455
Files:
clangd/URI.cpp
unittests/clangd/URITests.cpp
Index: uni