[PATCH] D52390: [analyzer] Add StackSizeChecker to StaticAnalyzer

mate1214 abandoned this revision. mate1214 marked 24 inline comments as done. mate1214 added a comment. Herald added subscribers: dkrupp, nhaehnle, donat.nagy. Hi! Sorry for the delay. After considering the amount of requested tests and investigating the possibly reviewer friendly ways to split

[PATCH] D52390: [analyzer] Add StackSizeChecker to StaticAnalyzer

Szelethus added a comment. It'd also be good to have an entry in `www/analyzer/alpha_checks.html`. We've been neglecting it for long enough :/. Repository: rC Clang https://reviews.llvm.org/D52390 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D52390: [analyzer] Add StackSizeChecker to StaticAnalyzer

NoQ added a subscriber: rsmith. NoQ added a comment. In https://reviews.llvm.org/D52390#1251526, @NoQ wrote: > I approve moving the visitor into `lib/Analysis`. That's indeed the library > into which we dump all static analysis that is not specific to Static > Analyzer. @rsmith disagrees thou

[PATCH] D52390: [analyzer] Add StackSizeChecker to StaticAnalyzer

NoQ added a comment. @Szelethus, thank you a lot for covering this review! @mate1214, yes, please please split this up, like @Szelethus described. At the moment this patch is not only huge, it is very under-tested. Eg., the Visitor promises support for C++ temporaries (which can potentially be

[PATCH] D52390: [analyzer] Add StackSizeChecker to StaticAnalyzer

Szelethus added inline comments. Comment at: include/clang/StaticAnalyzer/Checkers/StackUsageMeasuringVisitor.h:102-111 + bool hasEmptyFlaggedUsageStored(const Stmt *S) const { +auto iter = StmtSubtreeUsages.find(S); +return iter != StmtSubtreeUsages.end() && +

[PATCH] D52390: [analyzer] Add StackSizeChecker to StaticAnalyzer

whisperity added a comment. One final nit apart from a few in-line comments (most of them are just arguing with @Szelethus anyways 😛): KB vs. KiB (remember how a 2 TB hard drive appears as 1.8 TB on your machine? Because it's TiB!) is one of my pet peeve