This revision was automatically updated to reflect the committed changes.
Closed by commit rL261545: [analyzer] Detect duplicate [super dealloc] calls
(authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D5238?vs=48447&id=48707#toc
Repository:
rL LLVM
http://reviews.llv
dcoughlin updated this revision to Diff 48447.
dcoughlin added a comment.
Addressed additional comments from Anna offline:
- "[super dealloc] called again" is OK as a path note but not good as an error
message. I've changed it to "[super dealloc] should not be called multiple
times".
- Added a
dcoughlin added a comment.
In http://reviews.llvm.org/D5238#348199, @zaks.anna wrote:
> Looks good, below are some comments which are mostly nits.
>
> What's the plan for bringing this out of alpha? Is it pending evaluation on
> real code?
I will first extend this checker to check for uses of
dcoughlin updated this revision to Diff 47514.
dcoughlin added a comment.
Address more of Anna's comments.
- Add a more explicit comment about checker in header comment
- Changed the checker to always use the receiver symbol rather than the self
symbol for clarity.
- Rework SuperDeallocBRVisitor
zaks.anna added a comment.
Looks good, below are some comments which are mostly nits.
What's the plan for bringing this out of alpha? Is it pending evaluation on
real code?
Comment at: lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp:11
@@ +10,3 @@
+// This defines ObjC
dcoughlin updated this revision to Diff 47412.
dcoughlin added a comment.
Updated this to address Anna's comments.
- I've made the state smaller. It is just now a set of SymbolRefs for methods
instances that have been dealloc'd.
- I've hoisted isSuperDeallocMessage() to early return when possibl
