This revision was automatically updated to reflect the committed changes.
Closed by commit rL342866: [clangd] Force Dex to respect symbol collector flags
(authored by omtcyfz, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52357?vs=16
kbobyrev updated this revision to Diff 166482.
kbobyrev marked 2 inline comments as done.
https://reviews.llvm.org/D52357
Files:
clang-tools-extra/clangd/index/dex/Dex.cpp
clang-tools-extra/unittests/clangd/DexTests.cpp
Index: clang-tools-extra/unittests/clangd/DexTests.cpp
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:184
+ // Filter symbols which are not indexed for code completion.
+ if (Req.RestrictForCodeCompletion)
---
kbobyrev updated this revision to Diff 166474.
kbobyrev marked an inline comment as done.
kbobyrev edited the summary of this revision.
kbobyrev added a comment.
`RestirctForCodeCompletion` and `!RestrictForCodeCompletion` are not mutually
exclusive.
https://reviews.llvm.org/D52357
Files:
cl
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Dex.cpp:27
+Token(Token::Kind::Sentinel, "Restricted For Code Completion");
+static const Token NotRestrictedForCodeCompletion =
+Token(Token::Kind::Sentinel, "Not Restricted For Code Completion"
kbobyrev created this revision.
kbobyrev added a reviewer: ioeric.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
`Dex` should utilize `FuzzyFindRequest.RestrictForCodeCompletion` flags and
omit symbols not meant for code completion wh
