[PATCH] D52259: [CUDA] Rearrange search path ordering to fix two test case failures

2018-09-21 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. IMO the current logic makes sense for the end user, prioritizing the environment guess over default paths. I think the tests should be fixed using `--cuda-path-ignore-env`, I remember I added this parameter to fix the failing tests when I wrote the code. Repository:

[PATCH] D52259: [CUDA] Rearrange search path ordering to fix two test case failures

2018-09-19 Thread Jiading Gai via Phabricator via cfe-commits
gaijiading updated this revision to Diff 166206. gaijiading added a comment. Apologies for having uploaded the wrong patch in my original review request. Please help review this version instead. Thanks. Repository: rC Clang https://reviews.llvm.org/D52259 Files: lib/Driver/ToolChains/Cuda

[PATCH] D52259: [CUDA] Rearrange search path ordering to fix two test case failures

2018-09-19 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. The patch does not seem to match the description and appears to have nothing to do with rearranging include paths. Could you check if these are the changes you intended to send for review. Repository: rC Clang https://reviews.llvm.org/D52259 _

[PATCH] D52259: [CUDA] Rearrange search path ordering to fix two test case failures

2018-09-18 Thread Jiading Gai via Phabricator via cfe-commits
gaijiading created this revision. gaijiading added reviewers: jlebar, Hahnfeld, dlj, tra. gaijiading added a project: clang. Herald added a subscriber: cfe-commits. Before this patch, when a system has the CUDA toolkit already installed to its default locations in /usr/local/cuda, there will be t