vsapsai added a comment.
Thanks for the fix.
Repository:
rL LLVM
https://reviews.llvm.org/D52191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
srhines added a comment.
Thanks @dblaikie for the quick fixup. I must have accidentally dropped the '!',
because I did run check-all to test the change.
Repository:
rL LLVM
https://reviews.llvm.org/D52191
___
cfe-commits mailing list
cfe-commits
dblaikie added a subscriber: srhines.
dblaikie added a comment.
Fixed in r342510 with the solution I mentioned up-thread.
Repository:
rL LLVM
https://reviews.llvm.org/D52191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Fixed in r342510 with the solution I mentioned up-thread.
On Tue, Sep 18, 2018 at 1:10 PM Volodymyr Sapsai via Phabricator <
revi...@reviews.llvm.org> wrote:
> vsapsai added a comment.
>
> Confirm that reverting the change locally fixes the tests. If nobody beats
> me to it, I plan to revert the
vsapsai added a comment.
Confirm that reverting the change locally fixes the tests. If nobody beats me
to it, I plan to revert the change in 30-60 minutes. @srhines, if you want to
fix it in another way and need more time, please let me know.
Repository:
rL LLVM
https://reviews.llvm.org/D52
rdhindsa added a comment.
It seems that following tests are broken with this change:
clang/test/Driver/clang_f_opts.c
clang/test/Frontend/gnu-mcount.c
Repository:
rL LLVM
https://reviews.llvm.org/D52191
___
cfe-commits mailing list
cfe-commits@l
vsapsai added a comment.
Seems like this change causes 2 test failures:
Clang :: Driver/clang_f_opts.c
Clang :: Frontend/gnu-mcount.c
Some of the failing bots are
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/15363/
http://green.lab.llvm.org/green/job/clang-stage1-cmake
dblaikie added a comment.
In https://reviews.llvm.org/D52191#1238648, @srhines wrote:
> In https://reviews.llvm.org/D52191#1238628, @dblaikie wrote:
>
> > Sure, looks good. Though my other/vague concern is why does this case error
> > about fomit-frame-pointer having no effect, but other things
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342501: Fix logic around determining use of frame pointer
with -pg. (authored by srhines, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52191?vs=165826&id=166007#toc
Repository:
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342501: Fix logic around determining use of frame pointer
with -pg. (authored by srhines, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52191
F
srhines added a comment.
In https://reviews.llvm.org/D52191#1238628, @dblaikie wrote:
> Sure, looks good. Though my other/vague concern is why does this case error
> about fomit-frame-pointer having no effect, but other things (like using
> -fomit-frame-pointer on a target that requires frame p
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Sure, looks good. Though my other/vague concern is why does this case error
about fomit-frame-pointer having no effect, but other things (like using
-fomit-frame-pointer on a target that r
srhines created this revision.
srhines added a reviewer: dblaikie.
Herald added a subscriber: cfe-commits.
As part of r342165, I rewrote the logic to check whether
-fno-omit-frame-pointer was passed after a -fomit-frame-pointer
argument. This CL switches that logic to use the consolidated
shouldUs
13 matches
Mail list logo
