[PATCH] D52118: [Loopinfo] Remove one latch case in getLoopID. NFC.

2018-09-17 Thread Michael Kruse via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342406: [Loopinfo] Remove one latch-case in getLoopID. NFC. (authored by Meinersbur, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52118?vs=

[PATCH] D52118: [Loopinfo] Remove one latch case in getLoopID. NFC.

2018-09-17 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur added a comment. In https://reviews.llvm.org/D52118#1235897, @jdoerfert wrote: > > save an iteration over the loop's basic blocks (which is what getLoopLatch > > does) > > I'm not sure this is true. getLoopLatch() in LoopInfoImpl.h > only traverses the children of the header in the

[PATCH] D52118: [Loopinfo] Remove one latch case in getLoopID. NFC.

2018-09-15 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. > save an iteration over the loop's basic blocks (which is what getLoopLatch > does) I'm not sure this is true. getLoopLatch() in LoopInfoImpl.h only traverses the children of the heade

[PATCH] D52118: [Loopinfo] Remove one latch case in getLoopID. NFC.

2018-09-14 Thread Michael Kruse via Phabricator via cfe-commits
Meinersbur created this revision. Meinersbur added reviewers: hfinkel, jdoerfert. getLoopID has different control flow for two cases: If there is a single loop latch and for any other number of loop latches (0 and more than one). The latter case should return the same result if there is a single