This revision was automatically updated to reflect the committed changes.
Closed by commit rL342362: [clangd] Get rid of AST matchers in SymbolCollector.
NFC (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D52089
Files
malaperle added a comment.
In https://reviews.llvm.org/D52089#1235851, @ioeric wrote:
> In https://reviews.llvm.org/D52089#1235777, @malaperle wrote:
>
> > why?
>
>
> I wanted to get some numbers and update the patch summary, but somehow
> forgot. Sorry about that and thanks for asking!
>
> The
ioeric added a comment.
In https://reviews.llvm.org/D52089#1235777, @malaperle wrote:
> why?
I wanted to get some numbers and update the patch summary, but somehow forgot.
Sorry about that and thanks for asking!
The AST matcher pops up in performance profile. Although not the most expensive
malaperle added a comment.
why?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
ioeric created this revision.
ioeric added reviewers: ilya-biryukov, kadircet.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D52089
Files:
clangd/index/SymbolCollector.cpp
Index: clangd/index/SymbolCollector.c
