ioeric accepted this revision.
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/PostingList.cpp:66
+ OS << "... ";
if (Index != std::end(Documents))
+ OS << *Index << " ...";
nit: should we drop the trailing `...` if Ind
kbobyrev updated this revision to Diff 165964.
kbobyrev added a comment.
@ioeric does this format look better?
https://reviews.llvm.org/D52084
Files:
clang-tools-extra/clangd/index/dex/Iterator.h
clang-tools-extra/clangd/index/dex/PostingList.cpp
clang-tools-extra/unittests/clangd/DexTest
ioeric accepted this revision.
ioeric added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/index/dex/Iterator.h:96
/// ChildN is N-th iterator child. Raw iterators over PostingList are
- /// represented as "[ID1, ID2, ..
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, sammccall, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Raw posting list iterator's `dump()` was changed in
https://reviews.llvm.org/rCTE342155, but the
