nik added a comment.
Herald added a subscriber: arphaman.
Herald added a project: clang.
I've bisected https://bugs.llvm.org/show_bug.cgi?id=42649 to this change.
Reverting this change fixes the issue.
Please look into it.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rC342528: [Sema] Do not load macros from preamble when
LoadExternal is false. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52079?vs=165969&id=166077#toc
Reposit
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D52079
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
ioeric updated this revision to Diff 165969.
ioeric added a comment.
- added lit test
Repository:
rC Clang
https://reviews.llvm.org/D52079
Files:
include/clang/Sema/CodeCompleteOptions.h
lib/Sema/SemaCodeComplete.cpp
test/Index/complete-pch-skip.cpp
Index: test/Index/complete-pch-skip
ilya-biryukov added a comment.
Maybe add a test?
There is `test/Index/complete-pch-skip.cpp` that checks similar things for AST
completions, adding macros there should be trivial.
Repository:
rC Clang
https://reviews.llvm.org/D52079
___
cfe-com
ioeric created this revision.
ioeric added a reviewer: ilya-biryukov.
Herald added a subscriber: cfe-commits.
Repository:
rC Clang
https://reviews.llvm.org/D52079
Files:
include/clang/Sema/CodeCompleteOptions.h
lib/Sema/SemaCodeComplete.cpp
Index: lib/Sema/SemaCodeComplete.cpp
===
