dberris updated this revision to Diff 165220.
dberris edited the summary of this revision.
dberris added a comment.
Revise description.
https://reviews.llvm.org/D52015
Files:
clang/lib/CodeGen/CodeGenFunction.cpp
clang/lib/CodeGen/CodeGenModule.cpp
clang/test/CodeGen/xray-attributes-suppo
dberris updated this revision to Diff 165219.
dberris added a subscriber: llvm-commits.
dberris added a comment.
This revision is now accepted and ready to land.
Adding an end-to-end test in compiler-rt to ensure that we are not suddenly
instrumenting functions that must not be instrumented. Maki
mboerger accepted this revision.
mboerger added a comment.
LGTM
https://reviews.llvm.org/D52015
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dberris planned changes to this revision.
dberris added a comment.
This change is still incomplete -- we should really only convey that the
'never' attribute gets preserved. Otherwise we're going to have to invent a way
to communicate to the XRay pass in LLVM that we should ignore the XRay
attr
dberris created this revision.
dberris added reviewers: mboerger, eizan.
Herald added subscribers: dexonsmith, mehdi_amini.
Before this change, we only emit the XRay attributes in LLVM IR when the
-fxray-instrument flag is provided. This may cause issues with thinlto
when the final binary is being
