This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE342456: [clangd] dexp tool uses llvm::cl to parse its
flags. (authored by sammccall, committed by ).
Herald added a subscriber: mgorny.
Changed prior to commit:
https://reviews.llvm.org/D51989?vs=1650
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D51989#1232099, @ilya-biryukov wrote:
> PS it'd be cool to have an interface to cl that does not rely on global
> state...
Yeah, I'm not sure if that's trivia
ilya-biryukov added a comment.
A small drive-by comment.
PS it'd be cool to have an interface to cl that does not rely on global state...
Comment at: clangd/index/dex/dexp/Dexp.cpp:163
+
+struct {
+ const char *Name;
Maybe use a named struct?
C++ is powerful,
sammccall created this revision.
sammccall added a reviewer: kbobyrev.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
We can use cl::ResetCommandLineParser() to support different types of
command-lines, as long as we're careful about option lif
