This revision was automatically updated to reflect the committed changes.
Closed by commit rC342060: [RISCV] Explicitly set an empty --sysroot in the
test (authored by rogfer01, committed by ).
Herald added a subscriber: jrtc27.
Repository:
rC Clang
https://reviews.llvm.org/D51972
Files:
te
rogfer01 added a comment.
Thanks I will do it shortly.
https://reviews.llvm.org/D51972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lewis-revill added a comment.
Great, go ahead.
https://reviews.llvm.org/D51972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 added a comment.
I can commit it.
https://reviews.llvm.org/D51972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lewis-revill added a comment.
@asb @kristina can we get this committed?
https://reviews.llvm.org/D51972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 added a comment.
Thanks for the review!
https://reviews.llvm.org/D51972
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lewis-revill accepted this revision.
lewis-revill added a comment.
This revision is now accepted and ready to land.
The reasoning seems sound for this testcase change. I think the behaviour of
`computeSysRoot()` makes sense under this condition since it follows what the
user specified, it's just
rogfer01 created this revision.
rogfer01 added reviewers: lewis-revill, asb, simoncook, kristina.
Herald added subscribers: jocewei, PkmX, rkruppe, the_o, brucehoult,
MartinMosbeck, mgrang, edward-jones, zzheng, shiva0217, kito-cheng, niosHD,
sabuasal, apazos, johnrusso, rbar.
In https://reviews
