This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE342137: [clangd] Use JSON format in benchmark requests
reader (authored by omtcyfz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51971?vs=165280&id=165281#toc
Repository:
rCTE
kbobyrev updated this revision to Diff 165280.
kbobyrev marked 2 inline comments as done.
https://reviews.llvm.org/D51971
Files:
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
clang-tools-extra/test/clangd/Inputs/requests.json
clang-tools-extra/test/clangd/Inputs/requests.log
clan
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:52
+ if (!JSONArray->getAsArray()) {
+llvm::errs() << "Error when parsing JSON arra
kbobyrev updated this revision to Diff 165277.
kbobyrev added a comment.
Fix a typo in test comments.
https://reviews.llvm.org/D51971
Files:
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
clang-tools-extra/test/clangd/Inputs/requests.json
clang-tools-extra/test/clangd/Inputs/reque
kbobyrev updated this revision to Diff 165276.
kbobyrev marked 2 inline comments as done.
https://reviews.llvm.org/D51971
Files:
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
clang-tools-extra/test/clangd/Inputs/requests.json
clang-tools-extra/test/clangd/Inputs/requests.log
clan
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:48
+llvm::errs() << "Error when parsing json requests file: "
+ << llvm::toString(JSONArray.takeError());
+exit(1);
We should only call
kbobyrev updated this revision to Diff 165248.
kbobyrev marked 3 inline comments as done.
https://reviews.llvm.org/D51971
Files:
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
clang-tools-extra/clangd/index/dex/Iterator.cpp
clang-tools-extra/test/clangd/Inputs/requests.json
clang-
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:47
+ if (!JSONArray || !JSONArray->getAsArray()) {
+llvm::errs() << "FATAL ERROR: Couldn't parse request.\n";
+exit(1);
If there was a json parsing er
kbobyrev updated this revision to Diff 165240.
kbobyrev added a comment.
Fix empty scope in `requests.json`: `%s/"::"/""/g`.
https://reviews.llvm.org/D51971
Files:
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
clang-tools-extra/test/clangd/Inputs/requests.json
clang-tools-extra/t
kbobyrev updated this revision to Diff 165235.
kbobyrev added a comment.
Fix the diff after rebase.
https://reviews.llvm.org/D51971
Files:
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
clang-tools-extra/test/clangd/Inputs/requests.json
clang-tools-extra/test/clangd/Inputs/request
kbobyrev updated this revision to Diff 165234.
kbobyrev added a comment.
Rebase on top of https://reviews.llvm.org/rL342123.
https://reviews.llvm.org/D51971
Files:
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
clang-tools-extra/test/clangd/Inputs/requests.json
clang-tools-extra/t
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:45
+ if (!JSONArray) {
+llvm::errs() << "Couldn't parse request.\n";
+ }
ilya-biryukov wrote:
> kbobyrev wrote:
> > ilya-biryukov wrote:
> > > Return from fun
kbobyrev updated this revision to Diff 165232.
kbobyrev marked 3 inline comments as done.
https://reviews.llvm.org/D51971
Files:
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
clang-tools-extra/test/clangd/Inputs/requests.json
clang-tools-extra/test/clangd/Inputs/requests.log
clan
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:45
+ if (!JSONArray) {
+llvm::errs() << "Couldn't parse request.\n";
+ }
kbobyrev wrote:
> ilya-biryukov wrote:
> > Return from function after error?
> I
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:45
+ if (!JSONArray) {
+llvm::errs() << "Couldn't parse request.\n";
+ }
ilya-biryukov wrote:
> Return from function after error?
I thought that this should p
kbobyrev updated this revision to Diff 165209.
kbobyrev marked 2 inline comments as done.
https://reviews.llvm.org/D51971
Files:
clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp
clang-tools-extra/test/clangd/Inputs/requests.json
clang-tools-extra/test/clangd/Inputs/requests.log
clan
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:45
+ if (!JSONArray) {
+llvm::errs() << "Couldn't parse request.\n";
+ }
Return from function after error?
Comment at: clang-tools-ext
kbobyrev updated this revision to Diff 165110.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
@ilya-biryukov thanks! I was assuming that the `StringRef` constructor parses
user-provided string :(
`llvm::json::Array` is used now.
https://reviews.llvm.org/D51971
Files:
c
ilya-biryukov added a comment.
In https://reviews.llvm.org/D51971#1232064, @kbobyrev wrote:
> Apparently, the parsing seems to be wrong; I should fix that first.
Oh, yeah, just use `llvm::json::parse`
https://reviews.llvm.org/D51971
___
cfe-commi
kbobyrev planned changes to this revision.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Apparently, the parsing seems to be wrong; I should fix that first.
https://reviews.llvm.org/D51971
___
cfe-commits mailing list
cfe-comm
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/benchmarks/IndexBenchmark.cpp:21
+using clang::clangd::loadIndex;
+using clang::clangd::SymbolIndex;
We don't need the usings, just shorten the name on usage sites (usages are
inside nam
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, ilya-biryukov.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
After `FuzzyFindRequest` JSON (de)serialization was introduced, it should
replace ad-hoc fuzzy-find request
22 matches
Mail list logo
