[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

This revision was automatically updated to reflect the committed changes. Closed by commit rL341921: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits (authored by omtcyfz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51860?vs=

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:440 /// return more than this, e.g. if it doesn't know which candidates are best. - size_t MaxCandidateCount = std::numeric_limits::max(); + uint32_t MaxCandidateCount = std::numeric_limits::m

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

kbobyrev updated this revision to Diff 164836. https://reviews.llvm.org/D51860 Files: clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/clangd/index/Index.h Index: clang-tools-extra/clangd/index/Index.h === --- clang-t

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:440 /// return more than this, e.g. if it doesn't know which candidates are best. - size_t MaxCandidateCount = std::numeric_limits::max(); + uint32_t MaxCandidateCount = std::numeric_limi

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:440 /// return more than this, e.g. if it doesn't know which candidates are best. - size_t MaxCandidateCount = std::numeric_limits::max(); + uint32_t MaxCandidateCount = std::numeric_limits::max

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:440 /// return more than this, e.g. if it doesn't know which candidates are best. - size_t MaxCandidateCount = std::numeric_limits::max(); + uint32_t MaxCandidateCount = std::numeric_limits::

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:440 /// return more than this, e.g. if it doesn't know which candidates are best. - size_t MaxCandidateCount = std::numeric_limits::max(); + uint32_t MaxCandidateCount = std::numeric_limi

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

ioeric accepted this revision. ioeric added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Index.h:440 /// return more than this, e.g. if it doesn't know which candidates are best. - size_t MaxCandidateCount = std:

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

kbobyrev updated this revision to Diff 164821. kbobyrev marked an inline comment as done. https://reviews.llvm.org/D51860 Files: clang-tools-extra/clangd/index/Index.cpp clang-tools-extra/clangd/index/Index.h Index: clang-tools-extra/clangd/index/Index.h

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/Index.h:440 /// return more than this, e.g. if it doesn't know which candidates are best. - size_t MaxCandidateCount = std::numeric_limits::max(); + uint32_t MaxCandidateCount = std::numeric_limits::m

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

sammccall added a comment. Why this change? (If you're changing it, `Optional` is probably clearer) https://reviews.llvm.org/D51860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/Index.cpp:186 + O.map("ProximityPaths", Request.ProximityPaths); + if (OK) +Request.MaxCandidateCount = MaxCandidateCount; I think we should not set `Request.MaxCandidateCount` if

[PATCH] D51860: [clangd] NFC: Use uint32_t for FuzzyFindRequest limits

kbobyrev created this revision. kbobyrev added reviewers: ioeric, sammccall. kbobyrev added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. https://reviews.llvm.org/D51860 Files: clang-tools-extra/clangd/index/Index.cpp clang-tools-