This revision was automatically updated to reflect the committed changes.
Closed by commit rL341734: Do not use optimized atomic libcalls for misaligned
atomics. (authored by rsmith, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51817
F
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341734: Do not use optimized atomic libcalls for misaligned
atomics. (authored by rsmith, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51817?vs=164517&id=164544#toc
Repository:
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/CodeGen/CGAtomic.cpp:949
case AtomicExpr::AO__opencl_atomic_compare_exchange_strong:
case AtomicExpr::AO__atomic_load_n:
case AtomicEx
rsmith added inline comments.
Comment at: lib/CodeGen/CGAtomic.cpp:949
case AtomicExpr::AO__opencl_atomic_compare_exchange_strong:
case AtomicExpr::AO__atomic_load_n:
case AtomicExpr::AO__atomic_store_n:
efriedma wrote:
> Is there any particular re
efriedma added inline comments.
Comment at: lib/CodeGen/CGAtomic.cpp:949
case AtomicExpr::AO__opencl_atomic_compare_exchange_strong:
case AtomicExpr::AO__atomic_load_n:
case AtomicExpr::AO__atomic_store_n:
Is there any particular reason to expect t
rsmith created this revision.
rsmith added reviewers: jyknight, t.p.northover.
Herald added a subscriber: jfb.
The optimized (__atomic_foo_) libcalls assume that the atomic object
is properly aligned, so should never be called on an underaligned
object.
This addresses one of several problems iden
