[PATCH] D51789: [clang] Add the no_extern_template attribute

2018-09-14 Thread Louis Dionne via Phabricator via cfe-commits
ldionne updated this revision to Diff 165569. ldionne added a comment. Change no_extern_template to exclude_from_explicit_instantiation Repository: rC Clang https://reviews.llvm.org/D51789 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/include/clan

[PATCH] D51789: [clang] Add the no_extern_template attribute

2018-09-14 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. In https://reviews.llvm.org/D51789#1235113, @rsmith wrote: > In https://reviews.llvm.org/D51789#1235100, @ldionne wrote: > > > In https://reviews.llvm.org/D51789#1235096, @rsmith wrote: > > > > > OK, so the semantics of this attribute are "explicit instantiation > > > de

[PATCH] D51789: [clang] Add the no_extern_template attribute

2018-09-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D51789#1235100, @ldionne wrote: > In https://reviews.llvm.org/D51789#1235096, @rsmith wrote: > > > OK, so the semantics of this attribute are "explicit instantiation > > declarations or definitions applied to the enclosing class do not apply to

[PATCH] D51789: [clang] Add the no_extern_template attribute

2018-09-14 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. In https://reviews.llvm.org/D51789#1235096, @rsmith wrote: > In https://reviews.llvm.org/D51789#1234903, @ldionne wrote: > > > I think now's a good time to bikeshed the name of the attribute if you have > > other suggestions. > > > OK, so the semantics of this attribute

[PATCH] D51789: [clang] Add the no_extern_template attribute

2018-09-14 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. In https://reviews.llvm.org/D51789#1234903, @ldionne wrote: > I think now's a good time to bikeshed the name of the attribute if you have > other suggestions. OK, so the semantics of this attribute are "explicit instantiation declarations or definitions applied to the

[PATCH] D51789: [clang] Add the no_extern_template attribute

2018-09-14 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. I think now's a good time to bikeshed the name of the attribute if you have other suggestions. Repository: rC Clang https://reviews.llvm.org/D51789 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llv