simark added a comment.
Thanks for your input. I have opened https://reviews.llvm.org/D53220, which
removes that option.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall added a comment.
In https://reviews.llvm.org/D51725#1261798, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D51725#1255695, @simark wrote:
>
> > But I am wondering what to do with the feature that allows clangd to change
> > compilation database path using the `didChangeConfigurat
ilya-biryukov added a subscriber: sammccall.
ilya-biryukov added a comment.
In https://reviews.llvm.org/D51725#1255695, @simark wrote:
> But I am wondering what to do with the feature that allows clangd to change
> compilation database path using the `didChangeConfiguration` notification.
> In
simark added a comment.
So I revisited this today. In the end, restarting clangd in our IDE works
well. It should be merged anytime soon:
https://github.com/theia-ide/theia/pull/3017
But I am wondering what to do with the feature that allows clangd to change
compilation database path using t
ilya-biryukov added a comment.
In https://reviews.llvm.org/D51725#1233254, @simark wrote:
> I am not sure I understand correctly your last point. Of course, when
> restarting clangd, we need to send again a `didOpen` for each file the user
> has currently open in the editor. But that should b
kadircet added inline comments.
Comment at: clangd/Protocol.h:368
+ /// both Optionals are instantiated.
+ llvm::Optional> compilationDatabasePath;
ilya-biryukov wrote:
> Not a big fan or something like this, but maybe give special meaning to empty
> path in
simark added a comment.
In https://reviews.llvm.org/D51725#1232748, @ilya-biryukov wrote:
> If this setting exposed directly the users in Theia or is it something that
> is exposed via a custom UI (e.g. choosing named build configs or something
> similar)?
It is through a custom UI, that we n
ilya-biryukov added a comment.
If this setting exposed directly the users in Theia or is it something that is
exposed via a custom UI (e.g. choosing named build configs or something
similar)?
In https://reviews.llvm.org/D51725#1232171, @simark wrote:
> I was assuming that restarting clangd mig
simark added a comment.
In https://reviews.llvm.org/D51725#1232092, @ilya-biryukov wrote:
> Wow, this is getting somewhat complicated.
>
> Have you considered rerunning clangd whenever someone changes an option like
> that?
> Would that be much more complicated on your side?
>
> Not opposed to
ilya-biryukov added a comment.
Wow, this is getting somewhat complicated.
Have you considered rerunning clangd whenever someone changes an option like
that?
Would that be much more complicated on your side?
Not opposed to having an option too, just want to be aware of the costs
involved on you
simark added a comment.
Not sure who should review this, please feel free to add anybody who would be
appropriate.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51725
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
simark updated this revision to Diff 164183.
simark added a comment.
Fix formatting.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51725
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/GlobalCompilationDatabase.cpp
clangd/GlobalCompilationDatabase.h
simark created this revision.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ioeric,
ilya-biryukov.
It is currently possible to tell clangd where to find the
compile_commands.json file through the initializationOptions or the
didChangeConfiguration message. However, it is no
13 matches
Mail list logo
