[PATCH] D51724: [clangd] Add "Deprecated" field to Symbol and CodeCompletion.

kadircet added inline comments. Comment at: unittests/clangd/SymbolCollectorTests.cpp:1020 + const std::string Header = R"( +void TestClangc() __attribute__((deprecated("", ""))); +void TestClangd(); No need for the optional parameters, ``` void TestCl

[PATCH] D51724: [clangd] Add "Deprecated" field to Symbol and CodeCompletion.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE341576: [clangd] Add "Deprecated" field to Symbol and CodeCompletion. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D51724?vs=164259&id=164260#toc Repository:

[PATCH] D51724: [clangd] Add "Deprecated" field to Symbol and CodeCompletion.

ioeric updated this revision to Diff 164259. ioeric added a comment. - merged with origin/master Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51724 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/Protocol.cpp clangd/Protocol.h clangd/Quality.cpp clangd

[PATCH] D51724: [clangd] Add "Deprecated" field to Symbol and CodeCompletion.

ioeric updated this revision to Diff 164258. ioeric marked 5 inline comments as done. ioeric added a comment. - addressed review comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51724 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/Protocol.cpp clangd

[PATCH] D51724: [clangd] Add "Deprecated" field to Symbol and CodeCompletion.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Agree with Kadir's comments. I'd just suggest reducing boilerplate a bit by taking some shortcuts. Comment at: clangd/index/Index.h:167 +enum class SymbolFlag : uint8

[PATCH] D51724: [clangd] Add "Deprecated" field to Symbol and CodeCompletion.

kadircet added inline comments. Comment at: clangd/index/Index.h:171 + /// See also isIndexedForCodeCompletion(). + IsIndexedForCodeCompletion = 1 << 0, + /// Indicates if the symbol is deprecated. nit: rename to IndexedForCodeCompletion, since it is more of a

[PATCH] D51724: [clangd] Add "Deprecated" field to Symbol and CodeCompletion.

ioeric updated this revision to Diff 164205. ioeric marked an inline comment as done. ioeric added a comment. - Pack flags in Symbol. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51724 Files: clangd/CodeComplete.cpp clangd/CodeComplete.h clangd/Protocol.cpp clangd/Pro

[PATCH] D51724: [clangd] Add "Deprecated" field to Symbol and CodeCompletion.

ioeric added inline comments. Comment at: clangd/Protocol.cpp:520 Result["additionalTextEdits"] = json::Array(CI.additionalTextEdits); + if (CI.deprecated) +Result["deprecated"] = CI.deprecated; sammccall wrote: > do we actually want this in JSON? > (ge

[PATCH] D51724: [clangd] Add "Deprecated" field to Symbol and CodeCompletion.

sammccall added a comment. I think you also need to update SymbolsYAML and Serialization. Comment at: clangd/Protocol.cpp:520 Result["additionalTextEdits"] = json::Array(CI.additionalTextEdits); + if (CI.deprecated) +Result["deprecated"] = CI.deprecated; -

[PATCH] D51724: [clangd] Add "Deprecated" field to Symbol and CodeCompletion.

ioeric created this revision. ioeric added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Also set "deprecated" field in LSP CompletionItem. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51724 Files: clangd/